This repository was archived by the owner on Sep 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 134
leafletDraw #184
Closed
nmccready
wants to merge
8
commits into
angular-ui:master
from
realtymaps:dev/nmccready/issue_105_leaflet_draw
Closed
leafletDraw #184
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d9dcdb7
fix(grunt, karma): huge glob would run out of memory. Removed
nmccready e559eac
coverage working
nmccready 7726839
fix(karma): coverage fixed and coverage report breaks down source
nmccready 79b2ea8
indenting to 2
nmccready 706071f
es6 of leafletDrawEvents
nmccready ddbd093
fix travis
nmccready 5a70b41
specs
nmccready d7d1669
fix travis
nmccready File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
global._ = require('lodash'); | ||
|
||
module.exports = function (grunt) { | ||
require('load-grunt-config')(grunt); | ||
const karmaRunner = require('./grunt/utils/karma'); | ||
|
||
module.exports = (grunt) => { | ||
require('load-grunt-config')(grunt); | ||
grunt.registerTask('karma', 'karma runner', function() { | ||
return karmaRunner('../../test/karma.conf.js',grunt)(this.async()); | ||
}); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start using 2 space indent. I'll fix it as I go; or I can do all the files in another follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editors tend to pick what's around, so it might be good idea to do one massive PR instead of leaving mixed styles behind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id rather not do all of it right now as it makes it even harder to review. Ill do it immediately after this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, absolutely, indentation PR has to have only spaces changed and nothing else.
We had this with Meanjs and it was good to watch for a moment with minimum amount of PR's pending.