-
-
Notifications
You must be signed in to change notification settings - Fork 360
Fixing 'Example Code' #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing 'Example Code' #245
Conversation
Wesley-Arrington
commented
Jul 12, 2018
- Made 'Example Code' a consistent size throughout document
- Added in 'Example Code' on several pages
- Added in missing programming language titles
Getting back up to date with upstream
I checked the changes in this PR for correctness and I can say there are no errors in it. I'd still like to pull @leios into this PR to discuss which size headline we want to use for "Example Code". In my opinion, it should be a H2 ( |
Yeah, agreed. If we could use |
I just asked myself: Why do we even have the language headlines ( |
Okay. The same question has been answered in another PR. I'd say we finish up this one first (change "Example Code" to |
Yeah. Agreed. I want to merge #242 soon, too. I think it will break some PR's, though. |
It shouldn't break too much. Git properly detected all the file moves, so it should be able to handle it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice standardization of code titles.
@Butt4cak3 I'll make that PR to remove language headlines :) |