-
-
Notifications
You must be signed in to change notification settings - Fork 360
Implement flat hierarchy. Fix some broken links. #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice. This was a lot of work and you even got the in-chapter links. I will be gutting a good amount of the Feel free to delete the stubs. I'll add the chapters back when I actually start working on them. I was little too ambitious in certain places. I am generally in-favour of the flat hierarchy, as long as the summary can be modified correctly. |
Ok, I deleted the |
The summary can be modified without consequences, so the AAA site looks like the old one with the flat hierarchy. The flat hierarchy also allows easier restructuring and is therefore more robust for the future. Let's wait what the others say to the flat hierarchy tho. |
If anyone is worried about broken links, we can easily fix that with redirects. I just found a plugin enabling us to do so. |
It there is no more discussion on this topic, I'll merge it before making my changes to the split-op chapter for this weekend's video. |
Notes (especially for @leios (since he adds and removes chapters mainly)):
If you (reading this) encounter any problems or have questions, feel free to ask me here or on Discord. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely improves the directory structure and is worth giving a try.
…. Move all algorithm chapter dirs into an "algorithms" folder.
This PR implements a flat hierarchy for all algorithm and algorithm related chapters.
There are discussion points left tho:
Principles of Code
chapters also be implemented in flat hierarchy or should we just leave them as is? // Leios will change that at some point, so I just don't do anything in hereRunge Kutta Methods
chapter? It links toEuler Methods
, but this doesn't exists. Should I link to something else or can this stub just get deleted? // Runge Kutta got removedPrinciples of Code
chapter be a sub-chapter of the newintroduction
chapter? // I won't do this in this PR anymore, also thePrinciples of Code
will get reworked by Leios