Skip to content

Removing All Language Headlines #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Removing All Language Headlines #246

merged 1 commit into from
Jul 15, 2018

Conversation

Wesley-Arrington
Copy link
Contributor

@Wesley-Arrington Wesley-Arrington commented Jul 12, 2018

@Butt4cak3 realized we no longer need the language headlines so this PR removes them. This can be seen in PR #245

@Butt4cak3
Copy link
Contributor

I can't review the entire PR right now, but why is it that your PRs always have these random "Merge pull request" commits in them?

@lulucca12
Copy link
Contributor

I think he has a fork of the project and commits to it but he has to pull the changes made in the original project so for this he created a pull request and forgot to remove it from the PR he makes on the original.

@Wesley-Arrington
Copy link
Contributor Author

Wesley-Arrington commented Jul 12, 2018

@lulucca12 is correct. Sorry about that I will make sure I don't do it in the future

@june128 june128 added the Chapter Edit This changes the archive's chapters. (md files are edited.) label Jul 12, 2018
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a positive change. Thank you.

@leios leios merged commit b7ed8e5 into algorithm-archivists:master Jul 15, 2018
@Wesley-Arrington Wesley-Arrington deleted the removingTitles branch September 10, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter Edit This changes the archive's chapters. (md files are edited.) General
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants