Add font_name to BitmapFont call for custom fonts #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
May 15, 2020
|
nice, we do recommend PILLOW for drawing fonts, the built in font is really minimal :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1841 to 1.0.2 from 1.0.1: > fixing blinka example > Merge pull request adafruit/Adafruit_CircuitPython_DS1841#2 from adafruit/pylint-update > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.9.3 from 3.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#80 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#79 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#21 from caternuson/example_update Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#32 from xdmtk/xdmtk-patch/font-bug Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#22 from kattni/comet-tail-exception Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#32 from FoamyGuy/button_debouncer_example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've been using this package as part of the
Adafruit_Python_SSD1306package for few weeks now and I've been having issues making calls to the text drawing function using custom font paths (and consequently custom fonts as well).As it is right now, any call made to
adafruit_ssd1306.SSD1306_I2C.text()with or without afont_name=parameter specified expects a filefont5x8.binin the current working directory of the calling script despite what may be specified, rendering thefont_name=keyword param useless.After some digging it looks like the
BitmapFontclass is never instantiated with thefont_nameparameter, despite theBitmapFontclass having a default parameter available to override. I have added thefont_nameparameter in the call to instantiateBitmapFontin this pull request, and it has fixed my build (allowing me to keep my font files out of the working directory of the active script).Hopefully this pull request helps and this repo is still alive and well. Thanks