-
Notifications
You must be signed in to change notification settings - Fork 45
Add tail_length exception, update example imports. #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looking into fixing the Pylint failure with now setting |
I forgot to note that you would revise the |
pylint should notice that if tail_length is None:
self._tail_length = int(len(pixel_object) / 4)
else:
self._tail_length = max(2, min(tail_length, len(pixel_object)))
self._color_step = 0.9 / self._tail_length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1841 to 1.0.2 from 1.0.1: > fixing blinka example > Merge pull request adafruit/Adafruit_CircuitPython_DS1841#2 from adafruit/pylint-update > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.9.3 from 3.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#80 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#79 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#21 from caternuson/example_update Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#32 from xdmtk/xdmtk-patch/font-bug Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#22 from kattni/comet-tail-exception Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#32 from FoamyGuy/button_debouncer_example
Added exception for
tail_length
on Comet animation - if it was too long before, it failed with a slicing error on the line containinganimations.animate()
which was incredibly cryptic.No idea why I thought I needed to make the example imports and usage more verbose. Thanks @dhalbert for noticing this.