-
Notifications
You must be signed in to change notification settings - Fork 71
Create “Gravity Pulls Pixel” program #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this! Please create a folder called Advanced Examples
within the examples
folder and move this file into that. There's definitely a place for it here, we simply need to create it!
As well the linting checks have failed through Travis on a couple of things. Please ping me if you need assistance with working through this.
Hi Kattni. How about we call the subfolder |
The style check doesn’t like
But don’t we prefer that to:
The other thing it didn’t like was a function’s formal parameters shadowing variables in the module scope. I got around it this time by renaming the module-level variables. Other solutions would be to disable the check, or move most of the top-level code into a new function so that those variables have function scope (as I did in another program, where you asked about it). For my own purposes, I would probably allow the variable shadowing, but I’m happy to fit in here with the way you like to do things. |
I would prefer it be called Having things lined up is a personal preference, however if you choose to do so, you must disable the pylint checks. I personally don't bother with lining things up, I go with proper spacing, but that is my preference. |
711baf5
to
037bf97
Compare
I rebased to combine commits, and force pushed. If this passes, it’s ready as far as I’m concerned. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
For the record, we don't mind long commit lists. :)
I don’t understand the Travis error. Also, is the space in |
Space should be ok, but we can underscore it instead for consistency. I don't think that's the issue. I think the issue is in how Travis looks to run pylint on the files. I believe we'll need to update |
@dcbriccetti Ok I need to get some help on this one. I know what needs to happen but not entirely how to do it, and I believe that we need to update some further tools to deal with a subfolder. This is something I believe we would have eventually needed to do anyway, it happens to be that you're the first test case for it! I appreciate your patience. I'll keep you posted. |
Sure! No rush. Glad to help you stretch things. |
@dcbriccetti Still looking into this, haven't been able to coordinate with the person I need to yet. Wanted to give you an update. |
Thanks. That’s thoughtful. |
@dcbriccetti Please make the following change to
with
And let's see if that appeases Travis! |
@dcbriccetti Thank you for making the change. I'm looking into this further. |
Thanks for your patience! We've sorted it. |
Hurray! |
yayy! |
🎉 🎉 HUZZAH! 🎉 🎉 |
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#67 from dcbriccetti/gravity_pulls_pixel > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#66 from jepler/audiocore Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.8.0 from 1.7.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#57 from mscosti/ap_mode
This program uses the Circuit Playground Express’s accelerometer to position
a white pixel as if gravity were pulling it.
This may be too complicated to belong here. Please let me know if it is, and if there’s somewhere else within Adafruit where it could be useful. Otherwise I’ll just publish it within my own sphere.
Video here: https://youtu.be/sZ4tNOUKRpw