Skip to content

Fix Example Bundling When 'examples' In Subfolder Name #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

sommersoft
Copy link
Collaborator

As discovered in Adafruit_CircuitPython_CircuitPlayground PR #67, if a subfolder in the examples directory contained the word examples the file path would be truncated.

This fixes the truncation when dealing with the examples folder. Example using the above PR:

Generating VERSIONS

Zipping
test-examples-800ee1a/examples/circuitplayground_acceleration.py 155 512
test-examples-800ee1a/examples/circuitplayground_temperture.py 453 512
test-examples-800ee1a/examples/circuitplayground_light_plotter.py 394 512
test-examples-800ee1a/examples/circuitplayground_play_tone.py 247 512
test-examples-800ee1a/examples/circuitplayground_touch_pixel_fill_rainbow.py 1030 1536
test-examples-800ee1a/examples/circuitplayground_tapdetect.py 149 512
test-examples-800ee1a/examples/circuitplayground_play_file.py 411 512
test-examples-800ee1a/examples/circuitplayground_play_tone_buttons.py 268 512
test-examples-800ee1a/examples/circuitplayground_slide_switch_red_led_short.py 265 512
test-examples-800ee1a/examples/circuitplayground_temperature_neopixels.py 1134 1536
test-examples-800ee1a/examples/circuitplayground_tapdetect_single_double.py 527 1024
test-examples-800ee1a/examples/circuitplayground_ir_transmit.py 1354 1536
test-examples-800ee1a/examples/circuitplayground_neopixel_0_1.py 252 512
test-examples-800ee1a/examples/circuitplayground_red_led.py 140 512
test-examples-800ee1a/examples/circuitplayground_touched.py 452 512
test-examples-800ee1a/examples/circuitplayground_temperture_plotter.py 526 1024
test-examples-800ee1a/examples/circuitplayground_touch_pixel_rainbow.py 1017 1024
test-examples-800ee1a/examples/circuitplayground_buttons_1_neopixel.py 532 1024
test-examples-800ee1a/examples/circuitplayground_tone.py 207 512
test-examples-800ee1a/examples/circuitplayground_shake.py 140 512
test-examples-800ee1a/examples/circuitplayground_tap_red_led.py 396 512
test-examples-800ee1a/examples/circuitplayground_play_file_buttons.py 563 1024
test-examples-800ee1a/examples/circuitplayground_buttons_neopixels.py 565 1024
test-examples-800ee1a/examples/circuitplayground_slide_switch_red_led.py 345 512
test-examples-800ee1a/examples/circuitplayground_acceleration_neopixels.py 952 1024
test-examples-800ee1a/examples/circuitplayground_sound_meter.py 1871 2048
test-examples-800ee1a/examples/circuitplayground_button_b.py 432 512
test-examples-800ee1a/examples/circuitplayground_light_neopixels.py 929 1024
test-examples-800ee1a/examples/circuitplayground_red_led_blinky.py 284 512
test-examples-800ee1a/examples/circuitplayground_light.py 353 512
test-examples-800ee1a/examples/circuitplayground_slide_switch.py 283 512
test-examples-800ee1a/examples/circuitplayground_ir_receive.py 1480 1536
test-examples-800ee1a/examples/circuitplayground_button_a.py 227 512
test-examples-800ee1a/examples/circuitplayground_red_led_blnky_short.py 301 512
test-examples-800ee1a/examples/circuitplayground_pixels_simpletest.py 961 1024
test-examples-800ee1a/examples/advanced_examples/circuitplayground_acceleration_mapping_neopixels.py 1860 2048
test-examples-800ee1a/examples/advanced_examples/circuitplayground_gravity_pulls_pixel.py 3367 3584

Regression test on the full bundle also passed.

@sommersoft sommersoft requested review from tannewt and kattni August 18, 2019 13:26
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! 🌮

@kattni kattni merged commit 26ca873 into adafruit:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants