express.py: adapt to 'audiocore', retaining compatibility with earlier versions #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility with earlier versions
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 19, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#67 from dcbriccetti/gravity_pulls_pixel > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#66 from jepler/audiocore Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.8.0 from 1.7.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#57 from mscosti/ap_mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing performed: None, I gave away my CPX.
I made and tested similar changes earlier on a CPX with 4.1 and 5.0, freezing the module in with the circuitpython build, and it seemed to work.
I anticipate having another CPX in hand next week, I'll perform testing and follow up here if nobody else has been able to validate these changes.