Manage courses #307

orronai · 2021-09-18T07:37:53Z

Added course and usercourses tables
Added columns to exercise table
Fixed the upload method
Fixed some templates

- Added tables of courses and usercourses - Added some columns to exercise - Fixed the view template and user template - Fixed the upload method

lgtm-com · 2021-09-18T07:52:32Z

This pull request introduces 1 alert when merging 68d06ae into a04bab5 - view on LGTM.com

new alerts:

1 for Self assignment

codecov · 2021-09-18T08:08:11Z

Codecov Report

Merging #307 (1aa7b55) into master (cf0ec2f) will decrease coverage by 0.91%.
The diff coverage is 69.53%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   84.29%   83.37%   -0.92%     
==========================================
  Files          60       61       +1     
  Lines        2578     2683     +105     
==========================================
+ Hits         2173     2237      +64     
- Misses        405      446      +41

Impacted Files	Coverage Δ
lms/utils/courses.py	`0.00% <0.00%> (ø)`
lms/lmsdb/bootstrap.py	`16.26% <13.51%> (-0.60%)`	⬇️
lms/models/upload.py	`93.75% <90.90%> (+2.63%)`	⬆️
lms/lmsdb/models.py	`90.07% <96.07%> (-1.16%)`	⬇️
lms/lmsweb/views.py	`92.80% <100.00%> (+0.81%)`	⬆️
lms/extractors/base.py	`92.18% <0.00%> (+1.56%)`	⬆️
lms/extractors/textfile.py	`100.00% <0.00%> (+3.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0ec2f...1aa7b55. Read the comment docs.

lgtm-com · 2021-09-18T08:35:32Z

This pull request introduces 1 alert when merging 8e92e7a into a04bab5 - view on LGTM.com

new alerts:

1 for Self assignment

lms/lmsdb/models.py

lms/lmsweb/views.py

lms/templates/user.html

lms/lmsdb/models.py

lms/models/upload.py

- Added fields as asked

lgtm-com · 2021-09-21T13:17:58Z

This pull request introduces 1 alert when merging 2408d06 into cd74a56 - view on LGTM.com

new alerts:

1 for Self assignment

Co-authored-by: Sourcery AI <>

yammesicka

Awesome job! You should put the work you've invested in this system on your portfolio, really :)

I've added few notes, please take a look.

lms/lmsdb/models.py

lms/lmsweb/views.py

lms/templates/navbar.html

yammesicka · 2021-09-25T00:35:55Z

lms/lmsdb/models.py

+    course = ForeignKeyField(Course, backref='exercise')
+    number = IntegerField()


These should be in the migrations

Because these fields aren't nullable, what do you think about this kind of migration:

Creating a Course - (I need more info about it like the name of it and date).

Creating UserCourses objects for all users in the db and connect them to the Course we've created.

Adding the Course to this course column.

Adding the exercise id to the exercise number.

We might want to automatically fill this value according to the last number for this course in the database

lms/lmsdb/models.py

tests/test_extractor.py

lms/utils/courses.py

lms/lmsdb/models.py

lms/models/upload.py

- added a test - changed a function signature

lms/lmsdb/models.py

yammesicka

Awesome job, we're close to approval :)

… manage-courses

yammesicka

Great job! 🤩

lms/static/my.css

lms/lmsweb/views.py

lms/lmsdb/models.py

lms/templates/navbar.html

… manage-courses

lms/lmsdb/models.py

yammesicka · 2021-10-02T12:36:49Z

lms/lmsdb/models.py

+    course = ForeignKeyField(Course, backref='exercise')
+    number = IntegerField()


We might want to automatically fill this value according to the last number for this course in the database

tests/test_users.py

tests/test_extractor.py

lms/templates/navbar.html

lms/templates/exercises.html

lms/static/my.css

sourcery-ai · 2021-10-03T18:49:43Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.12%.

Quality metrics	Before	After	Change
Complexity	1.41 ⭐	1.38 ⭐	-0.03 👍
Method Length	42.53 ⭐	42.61 ⭐	0.08 👎
Working memory	6.94 🙂	6.99 🙂	0.05 👎
Quality	78.76% ⭐	78.64% ⭐	-0.12% 👎

Other metrics	Before	After	Change
Lines	2772	3040	268

Changed files	Quality Before	Quality After	Quality Change
lms/lmsdb/bootstrap.py	78.06% ⭐	79.27% ⭐	1.21% 👍
lms/lmsdb/models.py	84.53% ⭐	84.56% ⭐	0.03% 👍
lms/lmsweb/views.py	74.55% 🙂	74.73% 🙂	0.18% 👍
lms/models/upload.py	74.00% 🙂	70.62% 🙂	-3.38% 👎
tests/conftest.py	91.17% ⭐	91.28% ⭐	0.11% 👍
tests/test_exercises.py	79.22% ⭐	70.00% 🙂	-9.22% 👎
tests/test_extractor.py	82.36% ⭐	81.04% ⭐	-1.32% 👎
tests/test_solutions.py	67.75% 🙂	67.67% 🙂	-0.08% 👎
tests/test_users.py	82.51% ⭐	82.92% ⭐	0.41% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
lms/lmsweb/views.py	comment	13 🙂	202 😞	8 🙂	50.15% 🙂	Try splitting into smaller methods
tests/test_solutions.py	TestSolutionBridge.test_staff_and_user_comments	0 ⭐	236 ⛔	12 😞	52.40% 🙂	Try splitting into smaller methods. Extract out complex expressions
tests/test_solutions.py	TestSolutionBridge.test_share_solution_function	0 ⭐	248 ⛔	11 😞	53.48% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py	view	8 ⭐	140 😞	10 😞	56.16% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py	login	5 ⭐	129 😞	12 😞	56.69% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

orronai added 2 commits September 18, 2021 10:34

feat: Manage courses

2a60bfb

- Added tables of courses and usercourses - Added some columns to exercise - Fixed the view template and user template - Fixed the upload method

Fixed conflict

68d06ae

fixed a test

1fe197b

Added a test

8e92e7a

orronai linked an issue Sep 18, 2021 that may be closed by this pull request

Manage courses / course instances #287

Closed

yammesicka reviewed Sep 20, 2021

View reviewed changes

lms/lmsdb/models.py Show resolved Hide resolved

yammesicka reviewed Sep 20, 2021

View reviewed changes

lms/lmsdb/models.py Outdated Show resolved Hide resolved

yammesicka reviewed Sep 20, 2021

View reviewed changes

lms/lmsdb/models.py Outdated Show resolved Hide resolved

yammesicka reviewed Sep 20, 2021

View reviewed changes

lms/lmsweb/views.py Outdated Show resolved Hide resolved

yammesicka requested changes Sep 20, 2021

View reviewed changes

lms/templates/user.html Outdated Show resolved Hide resolved

lms/lmsdb/models.py Show resolved Hide resolved

lms/models/upload.py Outdated Show resolved Hide resolved

- Added few tests

2408d06

- Added fields as asked

Added a test and changed course' style

431f350

sourcery-ai bot mentioned this pull request Sep 24, 2021

Manage courses (Sourcery refactored) #312

Closed

orronai added 3 commits September 24, 2021 15:45

removed unforced string format

f40f81c

Add migration to last_course_viewed attribute`

e67e43a

Add migration to last_course_viewed attribute of User table

5d4f10c

sourcery-ai bot mentioned this pull request Sep 24, 2021

Manage courses (Sourcery refactored) #313

Merged

'Refactored by Sourcery' (#313)

ef1ac3f

Co-authored-by: Sourcery AI <>

yammesicka requested changes Sep 25, 2021

View reviewed changes

orronai added 7 commits September 25, 2021 10:16

Fixed paths, added return values

70b110e

added check registration functions to User and Course models

9ed9b4c

add navbar upload item

0fb4d19

Added migration

dd2419b

Add migration

737631d

fix migration

cec108b

Fix migration

5337283

orronai added 2 commits September 26, 2021 09:05

pulled master updates and fixed migration

054293e

fix migration

636e567

orronai requested a review from yammesicka September 26, 2021 06:21

yammesicka requested changes Sep 28, 2021

View reviewed changes

lms/lmsdb/models.py Show resolved Hide resolved

lms/models/upload.py Show resolved Hide resolved

- merged with master branch

b342b8f

- added a test - changed a function signature

yammesicka reviewed Sep 28, 2021

View reviewed changes

lms/lmsdb/models.py Outdated Show resolved Hide resolved

yammesicka requested changes Sep 28, 2021

View reviewed changes

orronai added 2 commits September 29, 2021 09:03

Merge branch 'master' of https://github.com/PythonFreeCourse/lms into…

03cf416

… manage-courses

- Changed course's column name

f5ba548

yammesicka requested changes Sep 30, 2021

View reviewed changes

orronai added 3 commits October 1, 2021 09:28

fix some issues

f7ad9e9

Merge branch 'master' of https://github.com/PythonFreeCourse/lms into…

5f941d2

… manage-courses

fix translations and some issues

df7b408

yammesicka requested changes Oct 2, 2021

View reviewed changes

changed column name and added the pre_save to the numebr column

f5f6fc0

yammesicka approved these changes Oct 3, 2021

View reviewed changes

lms/static/my.css Outdated Show resolved Hide resolved

removed css comment

1aa7b55

orronai merged commit f18eeca into master Oct 3, 2021

orronai deleted the manage-courses branch October 3, 2021 18:54

		course = ForeignKeyField(Course, backref='exercise')
		number = IntegerField()

Manage courses #307

Manage courses #307

Uh oh!

Conversation

orronai commented Sep 18, 2021

Uh oh!

lgtm-com bot commented Sep 18, 2021

Uh oh!

codecov bot commented Sep 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lgtm-com bot commented Sep 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Sep 21, 2021

Uh oh!

yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yammesicka Sep 25, 2021

Choose a reason for hiding this comment

Uh oh!

orronai Sep 25, 2021

Choose a reason for hiding this comment

Uh oh!

yammesicka Oct 2, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yammesicka Oct 2, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sourcery-ai bot commented Oct 3, 2021

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

Uh oh!

codecov bot commented Sep 18, 2021 •

edited

Loading