Skip to content

Update UNETR inference application to publish images for Clara Render Server #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2021

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Oct 13, 2021

In the PR, the application has been updated to use a newly introduced input and segmentation image publisher operator to publish the dataset for 3rd party Clara Render Server.
The publisher operator is interim and is needed for a specific demo that requires the Clara Render Server.

@MMelQin MMelQin requested a review from gigony October 13, 2021 06:46
@MMelQin MMelQin force-pushed the mqin/unetr_publish_images_for_RS branch from dc7bc48 to 80950d9 Compare October 13, 2021 06:49
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
…rver

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
@MMelQin MMelQin force-pushed the mqin/unetr_publish_images_for_RS branch from bacaea4 to 0280123 Compare October 14, 2021 20:50
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #182 (0932551) into main (4f70ba4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   35.29%   35.29%           
=======================================
  Files          64       64           
  Lines        3077     3077           
=======================================
  Hits         1086     1086           
  Misses       1991     1991           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f70ba4...0932551. Read the comment docs.

Copy link
Collaborator

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Ming!

op_output_folder_name = DataPath("saved_images_folder")
op_output.set(op_output_folder_name, "saved_images_folder")
op_output_folder_path = op_output.get("saved_images_folder").path
makedirs(op_output_folder_path, exist_ok=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use mkdir method on the object. It is okay as it is though.

@MMelQin MMelQin force-pushed the mqin/unetr_publish_images_for_RS branch from 9c9dfdf to 0932551 Compare October 14, 2021 21:33
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants