4/17 Bug fixes to Master #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r2 for ScriptAnalysis
Change the interface to ICustomAstVisitor instead of ICustomAstVisitor2 for ScriptAnalysis
Take Bug fixes to Raghu's branch
Add license header information to all source code
Fix test failures
Enforce minimum PowerShell Version for ScriptAnalyzer
Fix a bug where provide comment help is raised for non exported functions
For any advanced functions that have Verb as Get/Set/Stop/Update/Set/Reset that could potentially change the state of the system, we check if it has cmdletbinding specified. If so, the function should also support ShouldProcess
Also Add header to the file
Sorry. Pushed the wrong file. Corrected the message.
Add Tests for UseShouldProcessForStateChangingFunctions
Remove check for "Get-'" Get does not modify system Status
Change the example from "get" to "set"
Change the check. Replace "Get-" to "Restart". Get won't modify system status.
Conflicts: Rules/UseShouldProcessForStateChangingFunctions.cs
|
Looks like it includes all the changes we've made. Ready to be pulled into master. |
raghushantha
added a commit
that referenced
this pull request
Apr 17, 2015
[4/17] Take this week's bug fixes to Master branch
|
Thanks Yuting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.