Fix a bug where provide comment help is raised for non exported functions #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +32,8 @@ namespace Microsoft.Windows.Powershell.ScriptAnalyzer.BuiltinRules | |||
| [Export(typeof(IScriptRule))] | |||
| public class ProvideCommentHelp : SkipTypeDefinition, IScriptRule | |||
| { | |||
There was a problem hiding this comment.
Does this work if the functions are exported in the manifest psd1?
There was a problem hiding this comment.
This implementation does not look at psd1 file.
|
I think it is fine for now. Analyzing psm1 based on psd1 is a new feature by itself. Something to put in backlog. |
|
pls merge. changes are good. |
|
Thanks! Merged |
quoctruong
pushed a commit
that referenced
this pull request
Apr 15, 2015
Fix a bug where provide comment help is raised for non exported functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.