Change the interface to ICustomAstVisitor instead of ICustomAstVisitor2 for ScriptAnalysis #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r2 for ScriptAnalysis
| @@ -637,7 +637,7 @@ public int Compare(Tuple<int, int> t1, Tuple<int, int> t2) | |||
| /// <summary> | |||
| /// Class used to do variable analysis on the whole script | |||
| /// </summary> | |||
| public class ScriptAnalysis: ICustomAstVisitor2 | |||
| public class ScriptAnalysis: ICustomAstVisitor | |||
There was a problem hiding this comment.
Did you validate the changes by running all the rules + tests?
There was a problem hiding this comment.
I've run it on the applicable rules and it was okay. However, we do need to update a lot of other test cases. Going to do that in another pull request
|
great. pls merge to bugfixes branch |
quoctruong
pushed a commit
that referenced
this pull request
Apr 14, 2015
Change the interface to ICustomAstVisitor instead of ICustomAstVisitor2 for ScriptAnalysis
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.