Fix no copy_X problem #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-kriukov
requested review from
agorshk,
Alexsandruss and
Pahandrovich
as code owners
agorshk
approved these changes
Jan 28, 2022
dmitrii-kriukov
added a commit
to dmitrii-kriukov/scikit-learn_bench
that referenced
this pull request
Jan 28, 2022
* knn_svm * Revert "knn_svm" This reverts commit 6272ea5. * test copy * remove temp config * default parametrs * same problem on lasso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting the flag copy_X to False results in errors with multiple benchmark run and raising an implementation mismatch between sklearn and sklearnex
fix for elasticnet
fit_intercept was set to False by default (sklearn default is True), as a result --no-fit-intercept didn't affect fit_intercept parameter