Skip to content

Fix no copy_X problem #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sklearn_bench/elasticnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def main():
# Create our regression object
regr = ElasticNet(fit_intercept=params.fit_intercept, l1_ratio=params.l1_ratio,
alpha=params.alpha, tol=params.tol,
max_iter=params.maxiter, copy_X=False)
max_iter=params.maxiter)
# Time fit
fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, params=params)

Expand Down Expand Up @@ -63,7 +63,7 @@ def main():
if __name__ == "__main__":
parser = argparse.ArgumentParser(description='scikit-learn elastic-net regression '
'benchmark')
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=False,
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=True,
action='store_false',
help="Don't fit intercept (assume data already centered)")
parser.add_argument('--alpha', dest='alpha', type=float, default=1.0,
Expand Down
4 changes: 2 additions & 2 deletions sklearn_bench/lasso.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def main():

# Create our regression object
regr = Lasso(fit_intercept=params.fit_intercept, alpha=params.alpha,
tol=params.tol, max_iter=params.maxiter, copy_X=False)
tol=params.tol, max_iter=params.maxiter)

# Time fit
fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, params=params)
Expand Down Expand Up @@ -63,7 +63,7 @@ def main():
if __name__ == "__main__":
parser = argparse.ArgumentParser(description='scikit-learn lasso regression '
'benchmark')
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=False,
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=True,
action='store_false',
help="Don't fit intercept (assume data already centered)")
parser.add_argument('--alpha', dest='alpha', type=float, default=1.0,
Expand Down
2 changes: 1 addition & 1 deletion sklearn_bench/linear.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def main():

# Create our regression object
regr = LinearRegression(fit_intercept=params.fit_intercept,
n_jobs=params.n_jobs, copy_X=False)
n_jobs=params.n_jobs)

# Time fit
fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, params=params)
Expand Down