Skip to content

Commit 1c6b1d8

Browse files
Fix no copy_X problem (#108)
* knn_svm * Revert "knn_svm" This reverts commit 6272ea5. * test copy * remove temp config * default parametrs * same problem on lasso
1 parent aa4705e commit 1c6b1d8

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

sklearn_bench/elasticnet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def main():
2828
# Create our regression object
2929
regr = ElasticNet(fit_intercept=params.fit_intercept, l1_ratio=params.l1_ratio,
3030
alpha=params.alpha, tol=params.tol,
31-
max_iter=params.maxiter, copy_X=False)
31+
max_iter=params.maxiter)
3232
# Time fit
3333
fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, params=params)
3434

@@ -63,7 +63,7 @@ def main():
6363
if __name__ == "__main__":
6464
parser = argparse.ArgumentParser(description='scikit-learn elastic-net regression '
6565
'benchmark')
66-
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=False,
66+
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=True,
6767
action='store_false',
6868
help="Don't fit intercept (assume data already centered)")
6969
parser.add_argument('--alpha', dest='alpha', type=float, default=1.0,

sklearn_bench/lasso.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def main():
2727

2828
# Create our regression object
2929
regr = Lasso(fit_intercept=params.fit_intercept, alpha=params.alpha,
30-
tol=params.tol, max_iter=params.maxiter, copy_X=False)
30+
tol=params.tol, max_iter=params.maxiter)
3131

3232
# Time fit
3333
fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, params=params)
@@ -63,7 +63,7 @@ def main():
6363
if __name__ == "__main__":
6464
parser = argparse.ArgumentParser(description='scikit-learn lasso regression '
6565
'benchmark')
66-
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=False,
66+
parser.add_argument('--no-fit-intercept', dest='fit_intercept', default=True,
6767
action='store_false',
6868
help="Don't fit intercept (assume data already centered)")
6969
parser.add_argument('--alpha', dest='alpha', type=float, default=1.0,

sklearn_bench/linear.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def main():
2727

2828
# Create our regression object
2929
regr = LinearRegression(fit_intercept=params.fit_intercept,
30-
n_jobs=params.n_jobs, copy_X=False)
30+
n_jobs=params.n_jobs)
3131

3232
# Time fit
3333
fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, params=params)

0 commit comments

Comments
 (0)