Updates help writer to include all arguments #4562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the help writer tests to verify that all arguments are present in the help output. This ensures that users have access to comprehensive information about available command-line options.
There was a problem hiding this comment.
Pull Request Overview
This PR reorders and restores the UpdateWixVersionFile flag in the Arguments class and expands the help‐writer tests to verify that every CLI argument is included in the generated help output.
- Reintroduce and relocate
UpdateWixVersionFileinArguments.cs - Extend
HelpWriterTestswith mappings for all existing and new arguments - Ensure no argument flags are omitted from the help output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/GitVersion.App/Arguments.cs | Moved UpdateWixVersionFile into the update-options group |
| src/GitVersion.App.Tests/HelpWriterTests.cs | Added missing switches for new flags and reorganized mappings |
Comments suppressed due to low confidence (1)
src/GitVersion.App.Tests/HelpWriterTests.cs:21
- [nitpick] The dictionary of argument switches is unsorted, which can make future updates error-prone. Consider sorting entries alphabetically by key or grouping related flags to improve readability and maintainability.
var lookup = new Dictionary<string, string>
|
Thank you @arturcic for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the help writer tests to verify that all arguments are present in the help output. This ensures that users have access to comprehensive information about available command-line options.