Skip to content

Commit 2855256

Browse files
authored
Merge pull request #4562 from arturcic/fix/improve-help
Updates help writer to include all arguments
2 parents 388b4a3 + 5d2c260 commit 2855256

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed

src/GitVersion.App.Tests/HelpWriterTests.cs

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,33 @@ public void AllArgsAreInHelp()
1919
{
2020
var lookup = new Dictionary<string, string>
2121
{
22+
{ nameof(Arguments.IsHelp), "/?" },
23+
{ nameof(Arguments.IsVersion), "/version" },
24+
2225
{ nameof(Arguments.TargetUrl), "/url" },
2326
{ nameof(Arguments.TargetBranch), "/b" },
27+
{ nameof(Arguments.ClonePath), "/dynamicRepoLocation" },
28+
{ nameof(Arguments.CommitId), "/c" },
29+
2430
{ nameof(Arguments.LogFilePath) , "/l" },
31+
{ nameof(Arguments.Verbosity), "/verbosity" },
32+
{ nameof(Arguments.Output) , "/output" },
2533
{ nameof(Arguments.OutputFile) , "/outputfile" },
26-
{ nameof(Arguments.ClonePath), "/dynamicRepoLocation" },
27-
{ nameof(Arguments.IsHelp), "/?" },
28-
{ nameof(Arguments.IsVersion), "/version" },
34+
{ nameof(Arguments.ShowVariable), "/showvariable" },
35+
{ nameof(Arguments.Format), "/format" },
36+
2937
{ nameof(Arguments.UpdateWixVersionFile), "/updatewixversionfile" },
38+
{ nameof(Arguments.UpdateProjectFiles), "/updateprojectfiles" },
39+
{ nameof(Arguments.UpdateAssemblyInfo), "/updateassemblyinfo" },
40+
{ nameof(Arguments.EnsureAssemblyInfo), "/ensureassemblyinfo" },
41+
3042
{ nameof(Arguments.ConfigurationFile), "/config" },
31-
{ nameof(Arguments.Verbosity), "/verbosity" },
32-
{ nameof(Arguments.CommitId), "/c" },
3343
{ nameof(Arguments.ShowConfiguration), "/showconfig" },
3444
{ nameof(Arguments.OverrideConfiguration), "/overrideconfig" },
35-
{ nameof(Arguments.ShowVariable), "/showvariable" },
36-
{ nameof(Arguments.Format), "/format" }
45+
46+
{ nameof(Arguments.NoCache), "/nocache" },
47+
{ nameof(Arguments.NoFetch), "/nofetch" },
48+
{ nameof(Arguments.NoNormalize), "/nonormalize" },
3749
};
3850
var helpText = string.Empty;
3951

@@ -42,7 +54,7 @@ public void AllArgsAreInHelp()
4254
var ignored = new[]
4355
{
4456
nameof(Arguments.Authentication),
45-
nameof(Arguments.UpdateAssemblyInfoFileName)
57+
nameof(Arguments.UpdateAssemblyInfoFileName),
4658
};
4759
typeof(Arguments).GetFields()
4860
.Select(p => p.Name)

src/GitVersion.App/Arguments.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ internal class Arguments
1313

1414
public string? TargetPath;
1515

16-
public bool UpdateWixVersionFile;
17-
1816
public string? TargetUrl;
1917
public string? TargetBranch;
2018
public string? CommitId;
@@ -35,6 +33,7 @@ internal class Arguments
3533
public ISet<OutputType> Output = new HashSet<OutputType>();
3634
public Verbosity Verbosity = Verbosity.Normal;
3735

36+
public bool UpdateWixVersionFile;
3837
public bool UpdateProjectFiles;
3938
public bool UpdateAssemblyInfo;
4039
public bool EnsureAssemblyInfo;

0 commit comments

Comments
 (0)