Skip to content

Updates help writer to include all arguments #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/GitVersion.App.Tests/HelpWriterTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,33 @@ public void AllArgsAreInHelp()
{
var lookup = new Dictionary<string, string>
{
{ nameof(Arguments.IsHelp), "/?" },
{ nameof(Arguments.IsVersion), "/version" },

{ nameof(Arguments.TargetUrl), "/url" },
{ nameof(Arguments.TargetBranch), "/b" },
{ nameof(Arguments.ClonePath), "/dynamicRepoLocation" },
{ nameof(Arguments.CommitId), "/c" },

{ nameof(Arguments.LogFilePath) , "/l" },
{ nameof(Arguments.Verbosity), "/verbosity" },
{ nameof(Arguments.Output) , "/output" },
{ nameof(Arguments.OutputFile) , "/outputfile" },
{ nameof(Arguments.ClonePath), "/dynamicRepoLocation" },
{ nameof(Arguments.IsHelp), "/?" },
{ nameof(Arguments.IsVersion), "/version" },
{ nameof(Arguments.ShowVariable), "/showvariable" },
{ nameof(Arguments.Format), "/format" },

{ nameof(Arguments.UpdateWixVersionFile), "/updatewixversionfile" },
{ nameof(Arguments.UpdateProjectFiles), "/updateprojectfiles" },
{ nameof(Arguments.UpdateAssemblyInfo), "/updateassemblyinfo" },
{ nameof(Arguments.EnsureAssemblyInfo), "/ensureassemblyinfo" },

{ nameof(Arguments.ConfigurationFile), "/config" },
{ nameof(Arguments.Verbosity), "/verbosity" },
{ nameof(Arguments.CommitId), "/c" },
{ nameof(Arguments.ShowConfiguration), "/showconfig" },
{ nameof(Arguments.OverrideConfiguration), "/overrideconfig" },
{ nameof(Arguments.ShowVariable), "/showvariable" },
{ nameof(Arguments.Format), "/format" }

{ nameof(Arguments.NoCache), "/nocache" },
{ nameof(Arguments.NoFetch), "/nofetch" },
{ nameof(Arguments.NoNormalize), "/nonormalize" },
};
var helpText = string.Empty;

Expand All @@ -42,7 +54,7 @@ public void AllArgsAreInHelp()
var ignored = new[]
{
nameof(Arguments.Authentication),
nameof(Arguments.UpdateAssemblyInfoFileName)
nameof(Arguments.UpdateAssemblyInfoFileName),
};
typeof(Arguments).GetFields()
.Select(p => p.Name)
Expand Down
3 changes: 1 addition & 2 deletions src/GitVersion.App/Arguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ internal class Arguments

public string? TargetPath;

public bool UpdateWixVersionFile;

public string? TargetUrl;
public string? TargetBranch;
public string? CommitId;
Expand All @@ -35,6 +33,7 @@ internal class Arguments
public ISet<OutputType> Output = new HashSet<OutputType>();
public Verbosity Verbosity = Verbosity.Normal;

public bool UpdateWixVersionFile;
public bool UpdateProjectFiles;
public bool UpdateAssemblyInfo;
public bool EnsureAssemblyInfo;
Expand Down