Added Golang solutions of 'Two Pointers' tasks #75
Conversation
There was a problem hiding this comment.
Hi @lysunkin, thank you for creating a PR to the Go solutions.
To ensure consistency, please reformat each file to match the structure and conventions of the existing Go solutions for the Hash Maps and Sets chapter.
In addition, please ensure the code follows the same algorithm, variables names, etc.
as the original Python solutions.
FYI, @es-codigo has already opened a PR for some of the solutions in the Two Pointers chapter, so it might be better to work on a different chapter to avoid duplicate work.
You can view more guidelines about contributing to the repository here.
Signed-off-by: Slava Lysunkin <lysunkin@gmail.com>
lysunkin
force-pushed
the
GO_TWO_POINTERS
branch
from
44c30df to
3bf3e19
Compare
|
@Destiny-02 thanks for your review. I've aligned my PR with the requirements. |
| @@ -0,0 +1,30 @@ | |||
| func isAlnum(r rune) bool { | |||
There was a problem hiding this comment.
Could this function be moved below the isPalindromeValid function?
There was a problem hiding this comment.
Same for next_lexicographical_sequence.go
go/Two Pointers/pair_sum_sorted.go
Outdated
| return []int{left, right} | ||
| } | ||
| } | ||
| return []int{} |
There was a problem hiding this comment.
We have decided to use nil instead of []int{} for Go. You can check the conversation here: #56 (comment)
Signed-off-by: Slava Lysunkin <lysunkin@gmail.com>
Description
Added Golang solutions of 'Two Pointers' tasks