Skip to content

Docs(Go): Adding Go folder and solutions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

es-codigo
Copy link

Docs(Go): Adding Go folder and solutions

Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @es-codigo, thank you for making a PR to the solutions repository! Please check the below change(s) requested:

Stay true to existing variable/function naming, code comments and algorithm structure. Feel free to add additional comments for clarity, especially if any language-specific nuances are included.

Please add code comments to the Go solutions. The comments should match the comments from the official Python solutions.

Thanks again for your contributions! 🙂

@ineBallardin
Copy link
Contributor

@es-codigo @Destiny-02

There is no strict rule in the official Go documentation regarding file naming conventions, but the commonly accepted practice in the Go community is to use snake_case for file names. You can find several examples following this pattern in the Go documentation here.

I noticed that you've used camel case for file names. Since I'm contributing to the chapter two solutions and aligning with @Destiny-02 in the Discord community, I believe it would be beneficial to standardize our naming conventions to maintain consistency throughout the project.

Would you be open to renaming the files to follow the Go idiomatic style using snake case? This will make the codebase more aligned with best practices and easier to navigate for future contributors.

@Destiny-02
Copy link
Collaborator

Closing this PR because most of the Two Pointers Go solutions have been merged. Feel free to open another PR for the remaining brute-force solutions in the Two Pointers chapter.

@Destiny-02 Destiny-02 closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants