Go: Chapter 2 Hash Maps and Sets #56
Conversation
There was a problem hiding this comment.
Hi @ineBallardin, thank your for making a PR to the solutions repository! Please check the comments for the the change(s) requested.
Thanks again for your contributions! 🙂
| @@ -0,0 +1,29 @@ | |||
| package hashmapsandsets | |||
|
|
|||
| func LongestChainOfConsecutiveNumbers(nums []int) int { | |||
There was a problem hiding this comment.
should the function names use camel case?
There was a problem hiding this comment.
PascalCase/UpperCamelCase is used in these solutions instead of lowerCamelCase. Are there conventions around which one is used for regular functions?
| @@ -0,0 +1,29 @@ | |||
| package hashmapsandsets | |||
|
|
|||
| func LongestChainOfConsecutiveNumbers(nums []int) int { | |||
There was a problem hiding this comment.
PascalCase/UpperCamelCase is used in these solutions instead of lowerCamelCase. Are there conventions around which one is used for regular functions?
Use `return []int{}` instead of `return nil` in order to keep consistency with origial Python solition.
| return []int{i, idx} | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Apologies, I forgot to leave here the same suggestion to return an empty list instead of nil.
There was a problem hiding this comment.
I'm resolving this comment, as per our chat in Discord: Returning nil is a common and idiomatic way in Go to indicate the absence of a result, as it differentiates between "no result" and "an empty result."
We should keep 'nil' here.
| } | ||
| hashmap[x] = i | ||
| } | ||
| return []int{} |
There was a problem hiding this comment.
Apologies. I'm removing this suggestion per our chat in Discord: Returning nil is a common and idiomatic way in Go to indicate the absence of a result, as it differentiates between "no result" and "an empty result."
We should keep 'nil' here.
Return `nil` instead of `return []int{}`
Go Solutions for Chapter 2 - Hash Maps and Sets
This PR adds Go solutions for Chapter 2 - Hash Maps and Sets.
I followed the structure and naming conventions used in the official Python solutions to maintain consistency across languages. However, for variable and function names, I applied Go idiomatic conventions (e.g.,
camelCasefor variables and functions,snake_casefor file names). Despite these adaptations, the names remain equivalent to the original solutions to ensure clarity and consistency.All implementations have been tested to match the expected outputs. Let me know if any adjustments are needed!