Skip to content

Update jennyf/b2cwebapi from latest jmprieur/webappwebapib2c (and therefore master) #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 10, 2020
Merged

Update jennyf/b2cwebapi from latest jmprieur/webappwebapib2c (and therefore master) #286

merged 15 commits into from
Feb 10, 2020

Conversation

jmprieur
Copy link
Contributor

Purpose

This PR attempts to update jennyf/b2cwebapi

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

A sync from latest changes and PR accepted since last week

[x] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code

bgavrilMS and others added 15 commits January 29, 2020 14:33
@bgavrilMS
Update to MSAL 4.8.1
d975468
Fix for issue #273
1ec3c3f
Merge pull request #280 from Azure-Samples/tibre/273
12d1b6d 
Fix for issue 273
Merge branch 'master' into jmprieur/removingUis
f161eb3 
# Conflicts:
#	Microsoft.Identity.Web/AuthorizeForScopesAttribute.cs
@jmprieur
Adding details for the SQL cache
fea4d69 
Fixes #283 283
@egeskov
Handle tailing slashes in configured Authority and Instance (#278)
c2249d8 
* Updated references to 3.1.1
* Handle trailing slash and 'v2.0' in configured Authority value in AddProtectedWebApi method.
* Only add api:// to valid audiences if given as Client Id (not beginning with 'api://'.
* Handle optional configured ending slash for Instance in `TokenAcquisition`
@jmprieur
hotfix from #280 (the references are broken)
8c13f7f
@jmprieur
hotfix the AzureAD.UI versions: a lot of projects/folders are still i…
ec4f613 
…n 3.0.0
@multco-malan
Update MSGraphService.cs (#235)
21474e3 
Missing AuthenticatedClient in GetMyMemberOfGroupsAsync()
@jmprieur
Adding unit tests to #278 (#284)
0ab28e7 
* Adding unit tests to #278
and reverting the UI package upgrade as 3.1.1 has a bug

* Undoing what the refactoring tools in VS have changed

* Updating the AzureADxx.UI packages

* Adressing PR comments
@jmprieur
Merging from master and resolving the conflicts
686751e
@jmprieur
Merge branch 'jmprieur/removingUis' into jmprieur/webappwebapib2c
ad68fd0
@jmprieur
Fixing missing references
3a51a6a
@jmprieur
Uncommenting a needed line
b23fc76
@jmprieur
Merge branch 'jennyf/b2cwebapi' into jmprieur/webappwebapib2c
f40c079
@jmprieur jmprieur requested a review from jennyf19 February 10, 2020 16:24
@jmprieur
Copy link
Contributor Author

@jennyf19. this PR aims at bringing to your B2C branch the changes done this week (done since you created your branch), including merging PRs from customers, a couple of unit tests, bug fixes in term of references in particular.

jennyf19
jennyf19 approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19
Copy link
Contributor

@jmprieur thanks so much. appreciated. :)

In reply to: 584208876 [](ancestors = 584208876)

@jennyf19 jennyf19 merged commit b931371 into jennyf/b2cwebapi Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmprieur @jennyf19 @bgavrilMS @egeskov @multco-malan