Skip to content

Fix for issue 273 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

Fix for issue 273 #280

merged 1 commit into from
Feb 5, 2020

Conversation

TiagoBrenck
Copy link
Contributor

Purpose

Fix for issue #273

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow the steps mentioned : #273

What to Check

The exception is not thrown anymore

Other Information

@TiagoBrenck TiagoBrenck mentioned this pull request Feb 4, 2020
Closed
14 tasks
jmprieur
jmprieur approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Tiago

@TiagoBrenck TiagoBrenck requested a review from jennyf19 February 5, 2020 00:19
@TiagoBrenck TiagoBrenck merged commit 12d1b6d into master Feb 5, 2020
@TiagoBrenck TiagoBrenck deleted the tibre/273 branch February 5, 2020 17:45
jmprieur added a commit that referenced this pull request Feb 9, 2020
@jmprieur
hotfix from #280 (the references are broken)
8c13f7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@kalyankrishna1 kalyankrishna1 Awaiting requested review from kalyankrishna1

@jennyf19 jennyf19 Awaiting requested review from jennyf19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiagoBrenck @jmprieur