-
Notifications
You must be signed in to change notification settings - Fork 1k
Handle tailing slashes in configured Authority and Instance #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jennyf19 : interesting proposal to have Microsoft.Identity.Web more robust |
options.Audience, $"api://{options.Audience}" | ||
}; | ||
// The valid audience could be given as Client Id or as Uri. If it does not start with 'api://', this variant is added to the list of valid audiences. | ||
var validAudiences = new List<string> { options.Audience }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new List [](start = 37, length = 16)
I think we should do a HashSet<string>
here instead of a List<string>
would be nice to have test coverage for this, but i think it's related to our larger issue of lack of tests atm. :) LGTM otherwise. In reply to: 583803922 [](ancestors = 583803922) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @egeskov |
and reverting the UI package upgrade as 3.1.1 has a bug
@jmprieur FYI this had been taken care in the refactor PR. |
yes. It's in the renamingUi branch, with unit tests, moreover, now. |
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information