fix(state): do not expose FQCN in DeserializeProvider on PartialDenormalizationException

[alexndlm]

Q	A
Branch?	4.1
Tickets	Closes #7149
License	MIT
Doc PR

Also relates to https://github.com/api-platform/core/pull/6761/files

[soyuka]

It bothers me that we need to inject this but I guess there's no other solution unless we only use reflection?

[alexndlm]

Yes, if we want to use a short name, we need this service.

I would leave only a reflection, for simplicity. However, I can't assess how well it meets the general concept of the API Platform.

[soyuka]

Suggested change

	$normalizedType = $this->resourceMetadataCollectionFactory->create($expectedType)->getOperation()->getShortName();
	$normalizedType = $this->resourceMetadataCollectionFactory->create($expectedType)->getOperation()?->getShortName();

[alexndlm]

I have checked \ApiPlatform\Metadata\Resource\ResourceMetadataCollection::getOperation, it always returns Operation.

[soyuka]

Suggested change

	} catch (\Throwable) {
	} catch (OperationNotFoundException) {

[alexndlm]

Thanks

[soyuka]

I think this is quite sufficient actually (I thought we could re-use the current operation in the normalizers/denormalizers) but indeed in that case the type may be another one then the current operation's one...

[alexndlm]

Yes, we should fetch the operation exactly for class in $expectedType.

[soyuka]

I reverted the addition of the metadata factory reflection is enough imo.
For the future, note that introducing a new parameter in a constructor it needs to be nullable and we need to cover a bc layer (can't change the order of arguments). Anyways this is quite sufficient like this, many thanks!