fix(serializer): Fix exception message to not expose resource FQCN #7156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexndlm
commented
May 19, 2025
alexndlm
commented
| Q | A |
|---|---|
| Branch? | 4.1 |
| Tickets | Closes #7149 |
| License | MIT |
| Doc PR |
alexndlm
force-pushed
the
feature/serializer-fix-exceptions-message
branch
from
fa5812c to
4642f44
Compare
soyuka
reviewed
May 19, 2025
| @@ -228,13 +228,13 @@ public function denormalize(mixed $data, string $class, ?string $format = null, | |||
| throw new UnexpectedValueException($e->getMessage(), $e->getCode(), $e); | |||
| } | |||
|
|
|||
| throw NotNormalizableValueException::createForUnexpectedDataType(\sprintf('The type of the "%s" resource "string" (IRI), "%s" given.', $resourceClass, \gettype($data)), $data, [$resourceClass], $context['deserialization_path'] ?? null, true, $e->getCode(), $e); | |||
| throw NotNormalizableValueException::createForUnexpectedDataType($e->getMessage(), $data, [$resourceClass], $context['deserialization_path'] ?? null, true, $e->getCode(), $e); | |||
There was a problem hiding this comment.
can't we use $operation->getShortName() ?
There was a problem hiding this comment.
We can have FQCN in other places, like https://github.com/api-platform/core/pull/6761/files.
What do you think about #7158?
There was a problem hiding this comment.
I'll merge #7158, should I merge this one as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.