Skip to content

misc(seo) add canonical to the pages html, use trailing slash for con… #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2019
Merged

misc(seo) add canonical to the pages html, use trailing slash for con… #2999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad675d
misc(seo) add canonical to the pages html, use trailing slash for con…
EugeneHlushko May 7, 2019
5e2977a
misc(seo) fix sitemap to not mention index.html for each page
EugeneHlushko May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"lint:prose": "cp .proselintrc ~/ && proselint src/content",
"lint:links": "hyperlink -r dist/index.html --canonicalroot https://webpack.js.org/ -i --todo https://img.shields.io --todo https://codecov.io/gh --todo 'content-type-mismatch https://travis-ci.org' --todo 'Asset is used as both Html and Image' | tee internal-links.tap | tap-spot",
"linkcheck": "hyperlink -r dist/index.html --canonicalroot https://webpack.js.org/ --skip support__ --skip sidecar.gitter.im --skip vimdoc.sourceforge.net --skip img.shields.io --skip npmjs.com/package/ --skip opencollective.com/webpack --todo external-redirect | tee external-links.tap | tap-spot",
"sitemap": "cd dist && sitemap-static --prefix=https://webpack.js.org/ > sitemap.xml",
"sitemap": "cd dist && sitemap-static --pretty --prefix=https://webpack.js.org/ > sitemap.xml",
"serve": "npm run build && sirv start ./dist --port 4000",
"deploy": "gh-pages -d dist"
},
Expand Down
7 changes: 7 additions & 0 deletions src/server.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ const bundles = [
'/index.bundle.js'
];

// As github pages uses trailing slash, we need to provide it to canonicals for consistency
// between canonical href and final url served by github pages.
function enforceTrailingSlash (url) {
return url.replace(/\/?$/, '/');
}

// Export method for `SSGPlugin`
export default locals => {
let { assets } = locals.webpackStats.compilation;
Expand Down Expand Up @@ -49,6 +55,7 @@ export default locals => {
<link key={ path } rel="stylesheet" href={ `/${path}` } />
))}
<link rel="manifest" href="/manifest.json" />
<link rel="canonical" href={enforceTrailingSlash(locals.path)} />
</head>
<body>
<div id="root">
Expand Down