Skip to content

misc(seo) add canonical to the pages html, use trailing slash for con… #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2019

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented May 7, 2019

Update on sitemap, this is before:

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
    <url>
        <loc>https://webpack.js.org/index.html</loc>
    </url>
    <url>
        <loc>https://webpack.js.org/api/index.html</loc>
    </url>
    ...

And now it is:

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
    <url>
        <loc>https://webpack.js.org</loc>
    </url>
    <url>
        <loc>https://webpack.js.org/api</loc>
    </url>
    ...

@netlify
Copy link

netlify bot commented May 7, 2019

Preview is ready

Built with commit 5e2977a

https://deploy-preview-2999--webpackjsorg-netlify.netlify.com

@EugeneHlushko
Copy link
Member Author

EugeneHlushko commented May 8, 2019

@montogeek i found the root cause of this in analytics, will fix tonight.

Ready for review

@EugeneHlushko EugeneHlushko requested review from montogeek and removed request for montogeek May 8, 2019 15:39
@montogeek montogeek merged commit cac1fe1 into master May 8, 2019
@montogeek
Copy link
Member

Nice find!

@montogeek montogeek deleted the issues/2992 branch May 8, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation page is broken, 404 Not Found
4 participants