feat(misc) Add OG and Twitter metadata #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremenichelli
approved these changes
Aug 1, 2018
montogeek
requested changes
Aug 1, 2018
template.ejs
Outdated
|
|
||
| <meta property="og:site_name" content="Webpack" /> |
|
Please target |
|
@montogeek why rebuild? |
|
@EugeneHlushko because #2325 (comment) |
EugeneHlushko
force-pushed
the
feat/social
branch
from
517ccec to
e9e105a
Compare
|
ok its on |
montogeek
reviewed
Aug 1, 2018
| <meta property="twitter:card" content="summary" /> | ||
| <meta property="twitter:site" content="@webpack" /> | ||
| <meta property="twitter:creator" content="@webpack" /> | ||
| <meta property="twitter:domain" content="https://webpack.js.org/" /> |
There was a problem hiding this comment.
I am 99% sure that when sharing the link server will return static HTML.
I mean, there is not need for a React component for this.
There was a problem hiding this comment.
i am not sure what you mean, which react component?
There was a problem hiding this comment.
From the client side.
I mean, it is fine :)
There was a problem hiding this comment.
ah i thought it was change request, didnt see if thats approved or not :D
montogeek
approved these changes
Aug 1, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1984