fix(a11y) Make Dropdown more accessible #2325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tryzniak
commented
Jul 2, 2018
tryzniak
commented
- make it focusable
- allow navigation using arrow keys
- dismiss on escape
- make it focusable - allow navigation using arrow keys - dismiss on escape
|
@tryzniak Thank you so much for this work, but I am going to ask you a big favor, Could you please work on Our current setup is complicated, with a lot of patching and using outdated and unmaintained dependencies, we are been working on a rebuild which will solve those issues, being the main one reducing build time from 20 mins to 1 min. We can't accept more structural changes to a codebase that is already changing. Hope you understand, thanks again! |
|
No problem, Fernando! I’ll rework my pr like you asked :)
… On Jul 2, 2018, at 18:18, Fernando Montoya ***@***.***> wrote:
@tryzniak Thank you so much for this work, but I am going to ask you a big favor, Could you please work on rebuild branch instead?
Our current setup is complicated, with a lot of patching and using outdated and unmaintained dependencies, we are been working on a rebuild which will solve those issues, being the main one reducing build time from 20 mins to 1 min.
We can't accept more structural changes to a codebase that is already changing.
Hope you understand, thanks again!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.