Skip to content

Installation guide: Add note to install webpack-cli on v4 or higher #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2018
Merged

Installation guide: Add note to install webpack-cli on v4 or higher #1888

merged 1 commit into from
Mar 27, 2018

Conversation

itsMapleLeaf
Copy link

dhruvdutt
dhruvdutt approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also mention this in Basic Setup guide.

@montogeek montogeek mentioned this pull request Mar 27, 2018
Closed
@montogeek montogeek merged commit a60c9c9 into webpack:next Mar 27, 2018
@montogeek
Copy link
Member

Thanks!

montogeek pushed a commit that referenced this pull request Apr 7, 2018
@dhruvdutt @montogeek
docs(): Merge the next branch (#1993)
9814486 
* docs(guides) Fix error with filename + npm package. (#1886)

1) Webpack as default build to file main.js , not on bundle.js. 
2) Add npm install webpack-cli -D to npm install, If you do not do this console throw next: 
======================================================
The CLI moved into a separate package: webpack-cli.
Please install 'webpack-cli' in addition to webpack itself to use the CLI.
-> When using npm: npm install webpack-cli -D
-> When using yarn: yarn add webpack-cli -D
======================================================
So pls fix this, thank`s.

* docs(guides): Added info for v4 and webpack-cli (#1888)

* docs(configuration) Update snippets to comply with webpack v4+ (#1905)

* docs(configuration) Update snippets to comply with webpack v4+

* Expand mode for more info

* fix(docs) Remove git conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

@dhruvdutt dhruvdutt dhruvdutt approved these changes

Assignees
No one assigned
Labels
Enhancement Guides New Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsMapleLeaf @montogeek @dhruvdutt