Fix error with filename + npm package. #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Webpack as default build to file main.js , not on bundle.js. 2) Add npm install webpack-cli -D to npm install, If you do not do this console throw next: ====================================================== The CLI moved into a separate package: webpack-cli. Please install 'webpack-cli' in addition to webpack itself to use the CLI. -> When using npm: npm install webpack-cli -D -> When using yarn: yarn add webpack-cli -D ====================================================== So pls fix this, thank`s.
|
|
|
npm package change is ok, thanks. Edit: Also moved the base branch to |
dhruvdutt
suggested changes
Mar 15, 2018
| @@ -25,6 +25,7 @@ First let's create a directory, initialize npm, [install webpack locally](/guide | |||
| ``` bash | |||
| mkdir webpack-demo && cd webpack-demo | |||
| npm init -y | |||
| npm install --save-dev webpack | |||
There was a problem hiding this comment.
Remove this line. We already show the installation for webpack and webpack-cli in the next line.
npm install webpack webpack-cli --save-dev
|
Thanks! |
montogeek
pushed a commit
that referenced
this pull request
Apr 7, 2018
* docs(guides) Fix error with filename + npm package. (#1886) 1) Webpack as default build to file main.js , not on bundle.js. 2) Add npm install webpack-cli -D to npm install, If you do not do this console throw next: ====================================================== The CLI moved into a separate package: webpack-cli. Please install 'webpack-cli' in addition to webpack itself to use the CLI. -> When using npm: npm install webpack-cli -D -> When using yarn: yarn add webpack-cli -D ====================================================== So pls fix this, thank`s. * docs(guides): Added info for v4 and webpack-cli (#1888) * docs(configuration) Update snippets to comply with webpack v4+ (#1905) * docs(configuration) Update snippets to comply with webpack v4+ * Expand mode for more info * fix(docs) Remove git conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
======================================================
The CLI moved into a separate package: webpack-cli.
Please install 'webpack-cli' in addition to webpack itself to use the CLI.
-> When using npm: npm install webpack-cli -D
-> When using yarn: yarn add webpack-cli -D
======================================================
So pls fix this, thank`s.
describe your changes...