Skip to content

tweak: type checking and warn methods that conflict with internals #7318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

toBeTheLight
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: better checking and warn info

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yyx990803
Copy link
Member

Please provide more information on why these changes are needed.

@toBeTheLight
Copy link
Contributor Author

  1. The first change is adding warn info when key of data is reserved. When key is reserved, code ignore the key without giving a warn.
  2. The second change is about type checking of method value. Code methods[key] != null was added in pull request#3656 to checking for undefined properties.
    But when we call the method which type is number or string, not function, it will give a ambiguous error message too.
    And in the api document, it says type of method is function, so I changed methods[key] != null to typeof methods[key] !== 'function', and changed the warn info from has an undefined value to is not a function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants