Add undefined check for instance methods #3656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (methods[key] != null) { | ||
| vm[key] = bind(methods[key], vm) | ||
| } else { | ||
| warn(`The method ${key} on vue instance is undefined.`, vm) |
There was a problem hiding this comment.
can we add else if (process.env.NODE_ENV !== 'production') here so that the warning can be stripped?
zzz6519003
reviewed
Nov 18, 2016
| if (methods[key] != null) { | ||
| vm[key] = bind(methods[key], vm) | ||
| } else if (process.env.NODE_ENV !== 'production') { | ||
| warn(`The method ${key} on vue instance is undefined.`, vm) |
There was a problem hiding this comment.
curious why do you provide vm as a second variable? it will log vm?
There was a problem hiding this comment.
it's used to get the component name, if available:
https://github.com/vuejs/vue/blob/dev/src/core/util/debug.js#L10-L13
There was a problem hiding this comment.
Ahh I get it, You saved me!!!!!!!!!!
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an undefined property to
methodson vue components leads to a very ambiguous error message:Uncaught TypeError: Cannot read property 'length' of undefinedExample:
It's an easy mistake to make. This checks for undefined properties and warns if it finds one.