docs: fix prettier errors in zh docs #1581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
afontcu
approved these changes
Jun 14, 2020
|
Hi, thanks for the contribution! But we are now intentionally using |
|
I was worried about that. Let me know if I can help with anything such as
tweaking the prettier config to make the tests pass again.
…On Sun, Jun 14, 2020 at 8:16 PM GU Yiling ***@***.***> wrote:
Hi, thanks for the contribution! But we are now intentionally using *
instead of _ in the Chinese version because they are not equivalent in
GFM and _ would lead to some bad cases for the Chinese version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1581 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJGQP47D6OMTG4NWEAHPU3RWVR53ANCNFSM4N5Q7X3A>
.
|
|
Unfortunately Prettier doesn't seem to support configuring this. |
|
I opened this PR knowing there was a good chance it wouldn't work. Declining for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Fix lint in docs
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is how the changed bit of documentation looks now. I do not read Chinese so I cannot verify for certain that it is correct: