Skip to content

docs update for #1578 #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexmiddeleer
Copy link
Contributor

@alexmiddeleer alexmiddeleer commented Jun 14, 2020

Closes #1584

The PR fulfills these requirements:

Note that prettier found some issues in:
docs/zh/guides/common-tips.md
docs/zh/guides/getting-started.md

But I did not touch these files.

image

@alexmiddeleer
Copy link
Contributor Author

I attempted to fix the pre-existing prettier errors in #1581

@alexmiddeleer
Copy link
Contributor Author

Please let me know if there's anything you're still waiting on me for.

@afontcu
Copy link
Member

afontcu commented Jun 18, 2020

Looks good! There are some issues with Prettier. Would you mind running yarn format and push again? (I think they might be unrelated to your changes)

@alexmiddeleer
Copy link
Contributor Author

@afontcu I ran yarn format, but it resulted in the same code changes that I addressed in #1581. Those changes broke a desired convention in the /zh language docs.

@afontcu
Copy link
Member

afontcu commented Jun 22, 2020

Hm, weird. It def looks like it is related to zh docs. Will take a look, but otherwise your PR looks fine 👍 gonna try to find out what's going on and then merge it up.

thanks!! 🤗

@afontcu
Copy link
Member

afontcu commented Jul 8, 2020

Closing in favor of #1611! thanks for this :)

@afontcu afontcu closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attachToDocument deprecated and no documented substitute?
2 participants