Skip to content

custom blocks translation for ja #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2017
Merged

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Mar 24, 2017

No description provided.

@kazupon kazupon requested a review from ktsn March 24, 2017 12:54
@kazupon
Copy link
Member Author

kazupon commented Mar 24, 2017

/ping @ktsn

@@ -66,13 +66,13 @@ module.exports = {
}
```

## Runtime available docs
## 実行可能なドキュメント
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ドキュメントが実行可能なのではなく、実行時に利用可能だという意味だと思うので、「実行時に利用可能なドキュメント」はいかがでしょうか?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かにそちらの方がいいですね。
修正しました!

from review comment: vuejs#737 (comment)
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kazupon
Copy link
Member Author

kazupon commented Mar 24, 2017

レビュー、ありがとうございました!

@kazupon kazupon merged commit 9ce7003 into vuejs:master Mar 24, 2017
@kazupon kazupon deleted the improve/ja-docs branch March 24, 2017 15:23
kazupon added a commit that referenced this pull request Mar 24, 2017
kazupon added a commit that referenced this pull request Mar 24, 2017
* Revert "custom blocks translation for ja (#737)"

This reverts commit 9ce7003.

* Revert "Change let to var (#738)"

This reverts commit 31506f2.
kazupon added a commit that referenced this pull request Mar 24, 2017
* Revert "Change let to var" (#739)

* Revert "custom blocks translation for ja (#737)"

This reverts commit 9ce7003.

* Revert "Change let to var (#738)"

This reverts commit 31506f2.

* Revert "Revert "Change let to var" (#739)"

This reverts commit fc2dbc4.
BugKun pushed a commit to BugKun/mpvue-loader that referenced this pull request Jun 1, 2020
* pick up from #664

* translate #664

* improve title

from review comment: vuejs/vue-loader#737 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants