feat: Call custom block loaders with Component as argument
#664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat idea, mind adding a test case for this? |
hauptbenutzer
force-pushed
the
feature/call_custom_blocks
branch
from
198ca2f to
3d7d91d
Compare
|
Sure thing! I've added some example docs as well. |
hauptbenutzer
force-pushed
the
feature/call_custom_blocks
branch
from
3d7d91d to
f97b929
Compare
kazupon
approved these changes
Mar 1, 2017
phanan
reviewed
Mar 2, 2017
| this.callback(null, 'module.exports = function(Component) {Component.options.__docs = ' + | ||
| JSON.stringify(source) + | ||
| '}', map) | ||
| } |
There was a problem hiding this comment.
Nitpicky me here: I think we need a new line.
hauptbenutzer
force-pushed
the
feature/call_custom_blocks
branch
from
fbda704 to
a8a3aaf
Compare
|
/cc @yyx990803 |
|
@hauptbenutzer thanks for the PR and great docs example! |
Merged
kazupon
added a commit
to kazupon/vue-loader
that referenced
this pull request
Mar 24, 2017
kazupon
added a commit
to kazupon/vue-loader
that referenced
this pull request
Mar 24, 2017
kazupon
added a commit
that referenced
this pull request
Mar 24, 2017
* pick up from #664 * translate #664 * improve title from review comment: #737 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the idea of single file vue components and of being able to add custom blocks such as
<docs>. Although it is possible to pass arguments to the loader via attributes on the custom block tag, you cannot access theComponentfrom inside the loader. I needed that functionality to achieve the following.<docs>tag in the .vue fileoptions._docsso that it would be accessible during runtime.A very simple custom loader for this task could, for example, look like this:
So I changed the call of the customBlock to include
Component, if the result of therequireis a function. I'm not sure if this would break any existing workflows.If you think this use case is worth considering I'd be happy to supply the corresponding unit tests and docs.