Add docker based nginx deployment guide to docs #3323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
requested changes
Feb 20, 2019
docs/guide/deployment.md
Outdated
|
|
||
| ### Docker (Nginx) | ||
|
|
||
| Deploying your application using nginx inside of docker can be done easily with a minor modification of the nginx configuration. |
There was a problem hiding this comment.
It's unclear when you say minor modification of the nginx configuration, it would be nice if explicitly specify what we mean by the nginx configuration. Also, we can drop easily.
There was a problem hiding this comment.
I removed some of the confusing language.
docs/guide/deployment.md
Outdated
|
|
||
| 4. Create a `nginx.conf` file in the root of your project | ||
|
|
||
| This is a simple `nginx` configuration that falls back to the root `index.html` page for `404's`. This is necessary when using `pushState()` based routing. |
There was a problem hiding this comment.
It can be reworded to:
Following nginx configuration serves root index.html for page not found errors.
|
The process looks good to me. 👍 |
znck
approved these changes
Feb 21, 2019
|
@cregetycreg I don't understand the part with the 50x errors, if we don't have a server how is it possible to have a 50x error ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guide shows how to build a docker image to run a vue-cli based application with nginx. It has an example nginx config that does the appropriate pushState() based routing fallbacks for 404's.