Skip to content

Modify #ad width #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Modify #ad width #296

wants to merge 1 commit into from

Conversation

hiroppy
Copy link

@hiroppy hiroppy commented May 5, 2016

hello :)

I modified #ad width because #ad was overflowed at mobile screen.

before

scroll-test

check browsers

  • safari (iPhone 6s plus iOS 9.3)
  • chrome (nexus 5x)

@yyx990803
Copy link
Member

Thanks for the PR - however it seems the fix alone isn't enough so I had to apply a different fix. Still, thanks a lot!

@yyx990803 yyx990803 closed this May 5, 2016
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Oct 1, 2017
* fix style in list example

* update timestamp

* Add id to todo-item component (vuejs#1047)

* Add id to todo-item component

Give each todo item an id property to use as the key in the v-for loop. As discussed in #4825.

* Fix id generation in simple todos example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants