Add id to todo-item component #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give each todo item an id property to use as the key in the v-for loop. As discussed in #4825.
nickmessing
approved these changes
Jul 25, 2017
|
The id generation needed a slight tweak to prevent duplicates after removing some todos, then adding more - but otherwise looks good. 👍 |
|
great, thanks for reviewing it |
Merged
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Oct 1, 2017
* fix style in list example * update timestamp * Add id to todo-item component (vuejs#1047) * Add id to todo-item component Give each todo item an id property to use as the key in the v-for loop. As discussed in #4825. * Fix id generation in simple todos example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give each todo item an id property to use as the key in the v-for loop. As discussed in #4825.