Skip to content

Update benchmarks to use production version of react and compiled JSX templates. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

irae
Copy link

@irae irae commented Mar 4, 2014

For the sake of justice to React, I pulled down the production version.
Both Ember and Angular are using production versions already, I didn't check
the remainder of the frameworks.

Looks like my mac is very different from yours, some results are somewat different.
Regardless, I think this benchmark only scratches the surface, since every run is
a lot off the last one. Maybe running 100x the benchmark itself and taking averages
may make it more stable. But for now looks somewat better.

@irae
Copy link
Author

irae commented Mar 4, 2014

BTW, in order to compile the JSX files I just did npm install -g react-tools and then on the todo-benchmark folder, go the the react folder and do: jsx --extension jsx jsx/ js/. That's it.

@yyx990803
Copy link
Member

Please note a few things:

  • Current bench result is from a 10 run every average. Also the page states the hardware it is being run on so it doesn't make sense to replace the result with yours.
  • Every app is using unminified version. Ember uses an unminified "production" version because its dev version has a lot of extra internal asserts which hinders performance. For other libraries "production" is just a matter of minification.
  • The benchmark clock starts only when the page is actually rendered, so pre-compiling JSX theoretically has no effect on the results.

@irae
Copy link
Author

irae commented Mar 4, 2014

React does not provide a production unminified version, but they do have separate build time optimization before compressing. If you run the tests without my commit and then after my commit you will notice some 10-15% improvement.

You don't need to accept the json on the pull request, I can remove and rebase if you want, but it does change the performance. I did profile and a lot of the time spent was in reactPerf that only exists in the non minifyed version.

@yyx990803
Copy link
Member

cool, could you please:

  • remove the results.json changes
  • remove .module-cache/ files

I will replace all libs with minified production version and re-run the benchmark afterwards.

@yyx990803
Copy link
Member

6fb156a

All tested libs are using latest minified production build now. React did show considerable perf gain after using the prod version, thanks!

@yyx990803 yyx990803 closed this Mar 5, 2014
@irae irae deleted the react-production branch March 7, 2014 06:07
@irae
Copy link
Author

irae commented Mar 7, 2014

Many thanks for doing that :) sorry that I did not patch in time

dingyiming added a commit that referenced this pull request Dec 21, 2016
dingyiming pushed a commit that referenced this pull request Dec 21, 2016
Merge pull request #175 from 70data/2.0-cn
lex111 pushed a commit to lex111/vuejs.org that referenced this pull request Feb 3, 2018
Fix typos, replace some words
isatrio pushed a commit to isatrio/vuejs.org that referenced this pull request Mar 9, 2019
* Terjemahan Komponen Props

* Perbaikan Terjemahan Halaman Komponen Props vuejs#18

Mohon masukannya sekali lagi

* Update terjemahan comment, mengganti "pass = memasukkan" dengan "pass = mengoper", perbaikan lainnya

* kata bind/binding tidak diterjemahkan

* Terjemahan comment yang ketinggalan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants