Skip to content

Migration Guide > Transition Class Change の翻訳 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmmommm
Copy link
Contributor

@mmmommm mmmommm commented Nov 9, 2020

Description of Problem

resolve #125

Proposed Solution

Additional Information

https://github.com/vuejs-jp/ja.vuejs.org/blob/lang-ja/src/guide/migration/transition.md
こちらを翻訳しました。
17行目の下位互換性という翻訳と31行目のenterとleaveが広義であるというという翻訳が正しいのか確認をお願いしたいです。
レビューよろしくお願いいたします。

@netlify
Copy link

netlify bot commented Nov 9, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit d1733ee

https://deploy-preview-163--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつか変更コメント出させていただきました🙏

@mmmommm
Copy link
Contributor Author

mmmommm commented Nov 10, 2020

レビューありがとうございます、修正しました。
#155
こちらのPRで統一されていたので13行目を
2.x での構文とさせていただきました、問題あれば戻しますのでまた教えていただきたいです。

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
ありがとうございました 🙇

@potato4d potato4d merged commit 4bf5e33 into vuejs-jp:lang-ja Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration Guide > Transition Class Change の翻訳
2 participants