Skip to content

ci: Github Action workflow define : nvcheck,help tag #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2021

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Jun 30, 2020

このPRはnvcheckでの修正、tagチェックをpull-request時(とtagチェックは常に)に実施するGithub Actionsを入れるものです。

@tsuyoshicho tsuyoshicho force-pushed the feature/nvcheck branch 2 times, most recently from 833ab44 to e0f72cc Compare June 30, 2020 13:01
@tsuyoshicho tsuyoshicho marked this pull request as draft June 30, 2020 13:05
@tsuyoshicho

This comment has been minimized.

@tsuyoshicho tsuyoshicho force-pushed the feature/nvcheck branch 2 times, most recently from e1ac9ef to 00e80db Compare December 13, 2020 01:20
@tsuyoshicho
Copy link
Contributor Author

Image from Gyazo

Fixed, suggest only work.

@tsuyoshicho tsuyoshicho marked this pull request as ready for review December 13, 2020 01:29
@tsuyoshicho tsuyoshicho changed the title ci: Github Action workflow define : nvcheck ci: Github Action workflow define : nvcheck,help tag Feb 7, 2021
@tsuyoshicho
Copy link
Contributor Author

tsuyoshicho commented Apr 25, 2021

ping
@k-takata @h-east

すでにマージされたvimdoc-ja-workingのGHA化ですが
scriptのmake testが常時実施だった部分がフォローしきれていません

このPRが補完になるので、レビューしていただきたいです。
(というか、それがあるので、PRにTravisCI必須が設定できてたんですね...Travisの設定の読み解き力というか記憶がだいぶあいまいだった)

@h-east
Copy link
Member

h-east commented May 6, 2021

#901 Approved前にこのPRも気にはしていたのですが、依存関係が多かったりで今の私の手には負えないです。個人的には、とりあえずmergeして問題が起きたら頑張って対応する感じで行きたいです。

@k-takata
Copy link
Member

k-takata commented May 7, 2021

マージして様子見ましょう。

@k-takata k-takata merged commit e6a7aec into vim-jp:master May 7, 2021
@tsuyoshicho tsuyoshicho deleted the feature/nvcheck branch May 19, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants