-
Notifications
You must be signed in to change notification settings - Fork 6
ci: Github Action workflow define : push vimdoc-en gh-pages #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Github Action workflow define : push vimdoc-en gh-pages #15
Conversation
.github/workflows/generate.yml
Outdated
- master | ||
workflow_dispatch: | ||
schedule: | ||
- cron: '36 20 * * Sat' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以前は1日1回実行していたのですが、週1ですか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あー、すみません。元のTravisの設定から読めてなかったので、仮で入れてた面あります。(出すまでに考慮のつもりが忘れさられてた)
dailyに修正します。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
発動タイミングを、既存のログから同じ時間帯でdailyにしました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travisのcronは実際にはcronではなかったので、発動タイミングが徐々に遅くなるという代物でした。
なので、実際のところ、元の発動タイミングに意図はありませんw
thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見直していたらちょっと気になるところがありました。
push: | ||
branches: | ||
- master | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow_dispatch
は必要ないですよね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
手動生成できるので、動作確認にいいかなと思いましたが、削除しますか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
どういう使い方を想定されていますか?
最新のを実行し直すだけなら、最新のscheduled buildをre-runしても良さそうですが。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうですね...
re-runとしてではなく、新規にrunしたほうがいい場合があるかなと思ったというのはありますが、差がないですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
まー、re-runだと前のログが消えてしまうという問題はありますが…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あー、いまさら & このリポジトリだと意味がないのですが、思いだしました。
GitHub workflowのcronは、リポジトリ更新がないと60日で止るのですが
再開時に即座に更新を手動でしたいならあったほうがいいかな、的に考えてました。
まあ、不要なのは変りませんね(Vimの状況からすると)
env: | ||
GITHUB_TOKEN: ${{ secrets.VIMDOC_JP_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この行、もしかして不要ですか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ですね、すみません。
いま、追加修正を作っていますので、そちらで対応します。 |
ref vim-jp/vimdoc-ja-working#901
定期実行で vimdoc-en の gh-pages を更新します。
成果物