Stated minimum TSLint version on README.md #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't get the idea, this PR does bump the node minimum to 10 but only states that on the readme, right? |
|
Correct. Similar to how this probably coincidentally works on Node 7, this says 10 even though 8 and 9 probably (definitely) still work. |
|
They still work but as I mentioned on the original NodeJS issue, those reached End of Life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
As suggested in the issue.
Also bumps the Node minimum to 10 (#328), but doesn't otherwise overlap with the infrastructure changes in #338. FYI @KingDarBoja