-
Notifications
You must be signed in to change notification settings - Fork 101
Drop NodeJS 8 #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop NodeJS 8 #338
Conversation
@JoshuaKGoldberg ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CircleCI config change looks great, but let's avoid modifying source code for this one.
@JoshuaKGoldberg I will close this PR and open a new one with only the CircleCI and the package.json engine changes. But these stuff should be done on separate PRs:
Once again, my apologies for wasting your time when I made this PR as I tend to put extra stuff on my PRs (I couldn't resist 🙈 ). But been learning to control my need for fix everything at once. Cheers! |
Haha that's a struggle I have to get through the hard way... at least several times a year 😹. Thanks!
I sent a request to the typescript-eslint super-admins to install Renovate to take care of that. Good callout.
By which you mean.. updating to the newest typescript-eslint rules, since we're on ESLint? I'm up for discussing, but don't feel particularly passionate about them - feel free to open up issues for ones you'd like to enable. |
Ah yeah, ESLint ones, I got confused too 🙈 Looks like I haven't been up to date with latest changes. |
PR Checklist
status: accepting prs
Overview
This PR has few changes:
npm run eslint
.