Skip to content

Drop NodeJS 8 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Drop NodeJS 8 #338

wants to merge 4 commits into from

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

This PR has few changes:

  • Set minimum engine to Node +10.
  • Update dependencies to latest available version.
  • Provide missing return types on most error messages after running npm run eslint.
  • Export message on no-shadow-variable converter

@KingDarBoja KingDarBoja changed the title [WIP] Drop nodejs 8 [WIP] Drop NodeJS 8 Feb 15, 2020
@KingDarBoja
Copy link
Collaborator Author

@JoshuaKGoldberg ping!

@JoshuaKGoldberg JoshuaKGoldberg changed the title [WIP] Drop NodeJS 8 Drop NodeJS 8 Mar 26, 2020
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Mar 26, 2020
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CircleCI config change looks great, but let's avoid modifying source code for this one.

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Mar 28, 2020
@KingDarBoja
Copy link
Collaborator Author

@JoshuaKGoldberg I will close this PR and open a new one with only the CircleCI and the package.json engine changes.

But these stuff should be done on separate PRs:

  • Bump dependencies
  • TSLint rules (maybe migrate to ESLint?).

Once again, my apologies for wasting your time when I made this PR as I tend to put extra stuff on my PRs (I couldn't resist 🙈 ). But been learning to control my need for fix everything at once.

Cheers!

@JoshuaKGoldberg
Copy link
Member

Haha that's a struggle I have to get through the hard way... at least several times a year 😹. Thanks!

Bump dependencies

I sent a request to the typescript-eslint super-admins to install Renovate to take care of that. Good callout.

TSLint rules

By which you mean.. updating to the newest typescript-eslint rules, since we're on ESLint? I'm up for discussing, but don't feel particularly passionate about them - feel free to open up issues for ones you'd like to enable.

@KingDarBoja
Copy link
Collaborator Author

By which you mean.. updating to the newest typescript-eslint rules, since we're on ESLint? I'm up for discussing, but don't feel particularly passionate about them - feel free to open up issues for ones you'd like to enable.

Ah yeah, ESLint ones, I got confused too 🙈 Looks like I haven't been up to date with latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author The PR author should address requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for NodeJS 8
2 participants