PM- 228 Fix system information leak

scripts/build.js

@@ -10,7 +10,7 @@ process.on('unhandledRejection', err => {
 // Ensure environment variables are read.
 require('../config/env')
 
-console.log(`Build script is run with FILE_PICKER_API_KEY=${process.env.FILE_PICKER_API_KEY}`)
+console.log(`Build script is run`)
 
 const path = require('path')
 const chalk = require('chalk')
@@ -114,8 +114,10 @@ checkBrowsers(paths.appPath, isInteractive)
     }
   )
   .catch(err => {
-    if (err && err.message) {
-      console.error(err.message)
+    if (err && process.env.NODE_ENV === 'development') {
+      console.log(err)
+    } else {
+      console.error('An unexpected error occurred while build')
     }
     process.exit(1)
   })

scripts/start.js

@@ -111,8 +111,10 @@ checkBrowsers(paths.appPath, isInteractive)
     })
   })
   .catch(err => {
-    if (err && err.message) {
-      console.error(err.message)
+    if (err && process.env.NODE_ENV === 'development') {
+      console.log(err)
+    } else {
+      console.error('An error occurred while starting the development server')
     }
     process.exit(1)
   })

server.js

@@ -40,4 +40,4 @@ app.get('/*', (req, res) => res.sendFile(path.join(__dirname, 'build', 'index.ht
 const port = process.env.PORT || 3000
 app.listen(port)
 
-console.log(`App is listening on port ${port}`)
+console.log(`App is now listening...`)

src/components/ChallengeEditor/Description-Field/index.js

@@ -782,7 +782,11 @@ class DescriptionField extends Component {
     }).then(res => {
       onload(res)
     }).catch(err => {
-      console.log(err)
+      if (process.env.NODE_ENV === 'development') {
+        console.log(err)
+      } else {
+        console.log('An unexpected error occured while uploading image')
+      }
       onerror()
     })
   }

src/routes.js

@@ -94,7 +94,11 @@ class Routes extends React.Component {
     getFreshToken().then((token) => {
       this.props.saveToken(token)
     }).catch((error) => {
-      console.error(error.message)
+      if (process.env.NODE_ENV === 'development') {
+        console.error(error)
+      } else {
+        console.error('An unexpected error occurred while getting auth token')
+      }
       const redirectBackToUrl = encodeURIComponent(window.location.origin + this.props.location.pathname)
       window.location = `${ACCOUNTS_APP_LOGIN_URL}?retUrl=${redirectBackToUrl}`
     })

src/services/axiosWithAuth.js

@@ -18,7 +18,11 @@ export const getToken = () => {
           resolve(token)
         })
         .catch((err) => {
-          console.error(err)
+          if (process.env.NODE_ENV === 'development') {
+            console.log(err)
+          } else {
+            console.error('Error getting auth token')
+          }
           reject(err)
         })
     }
@@ -40,7 +44,11 @@ axiosInstance.interceptors.request.use(config => {
       return config
     })
     .catch((err) => {
-      console.error(err)
+      if (process.env.NODE_ENV === 'development') {
+        console.log(err)
+      } else {
+        console.error('An unexpected error occured while retrieving the auth token.')
+      }
       const redirectBackToUrl = window.location.origin
       window.location = ACCOUNTS_APP_LOGIN_URL + '?retUrl=' + redirectBackToUrl
     })